NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5c54f63

committed

Fix rare missing cancellations in Hot Standby.

The machinery around XLOG_HEAP2_CLEANUP_INFO failedto correctly pass through the necessary informationon latestRemovedXid, avoiding cancellations in someinfrequent concurrent update/cleanup scenarios.Backpatchable fix to 9.0Detailed bug report and fix by Noah Misch,backpatchable version by me.

1 parentbd6aca8 commit5c54f63Copy full SHA for 5c54f63

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- pruneheap.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/pruneheap.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ heap_page_prune(Relation relation, Buffer buffer, TransactionId OldestXmin,`
`173`	`173`	`* initialize the rest of our working state.`
`174`	`174`	`*/`
`175`	`175`	`prstate.new_prune_xid=InvalidTransactionId;`
`176`		`-prstate.latestRemovedXid=InvalidTransactionId;`
	`176`	`+prstate.latestRemovedXid=*latestRemovedXid;`
`177`	`177`	`prstate.nredirected=prstate.ndead=prstate.nunused=0;`
`178`	`178`	`memset(prstate.marked,0,sizeof(prstate.marked));`
`179`	`179`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5c54f63

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/pruneheap.c`

0 commit comments