NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5c53844

committed

Fix broken Assert() introduced by8e9a16a

Don't assert MultiXactIdIsRunning if the multi came from a tuple thathad been share-locked and later copied over to the new cluster bypg_upgrade. Doing that causes an error to be raised unnecessarily:MultiXactIdIsRunning is not open to the possibility that its argumentcame from a pg_upgraded tuple, and all its other callers are alreadychecking; but such multis cannot, obviously, have transactions stillrunning, so the assert is pointless.Noticed while investigating the bogus pg_multixact/offsets/0000 fileleft over by pg_upgrade, as reported by Andres Freund inhttp://www.postgresql.org/message-id/20140530121631.GE25431@alap3.anarazel.deBackpatch to 9.3, as the commit that introduced the buglet.

1 parenta2db7b7 commit5c53844Copy full SHA for 5c53844

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5326,8 +5326,14 @@ FreezeMultiXactId(MultiXactId multi, uint16 t_infomask,`
`5326`	`5326`	`* was a locker only, it can be removed without any further`
`5327`	`5327`	`* consideration; but if it contained an update, we might need to`
`5328`	`5328`	`* preserve it.`
	`5329`	`+ *`
	`5330`	`+ * Don't assert MultiXactIdIsRunning if the multi came from a`
	`5331`	`+ * pg_upgrade'd share-locked tuple, though, as doing that causes an`
	`5332`	`+ * error to be raised unnecessarily.`
`5329`	`5333`	`*/`
`5330`		`-Assert(!MultiXactIdIsRunning(multi));`
	`5334`	`+Assert((!(t_infomask&HEAP_LOCK_MASK)&&`
	`5335`	`+HEAP_XMAX_IS_LOCKED_ONLY(t_infomask))\|\|`
	`5336`	`+ !MultiXactIdIsRunning(multi));`
`5331`	`5337`	`if (HEAP_XMAX_IS_LOCKED_ONLY(t_infomask))`
`5332`	`5338`	`{`
`5333`	`5339`	`*flags \|=FRM_INVALIDATE_XMAX;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5c53844

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments