Commit5c1ce1b

committed

Remove tab completion for CREATE UNLOGGED MATERIALIZED VIEW.

Commit3bf3ab8 added support for unlogged materialized views,but commit3223b25 reverted that feature before it made it intoa release. However, the latter commit left the grammar andtab-completion support intact. This commit removes thetab-completion support to prevent psql from recommending boguscommands. I've opted to keep the grammar support so that theserver continues to emit a descriptive error when users try tocreate unlogged matviews.Reported-by: Daniel Westermann, px shiAuthor: Dagfinn Ilmari MannsåkerDiscussion:https://postgr.es/m/ZR0P278MB092093E92263DE16734208A5D2C59%40ZR0P278MB0920.CHEP278.PROD.OUTLOOK.COMDiscussion:https://postgr.es/m/CAAccyY%2BWg1Z-9tNfSwLmuZVgGOwqU5u1OP-RWcoAr2UZGuvN_w%40mail.gmail.com

1 parent0f12905 commit5c1ce1bCopy full SHA for 5c1ce1b

File tree

-8

lines changed

-8

lines changed

Lines changed: 2 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3267,15 +3267,9 @@ psql_completion(const char *text, int start, int end)`
`3267`	`3267`	`/* Complete "CREATE TEMP/TEMPORARY" with the possible temp objects */`
`3268`	`3268`	`elseif (TailMatches("CREATE","TEMP\|TEMPORARY"))`
`3269`	`3269`	`COMPLETE_WITH("SEQUENCE","TABLE","VIEW");`
`3270`		`-/* Complete "CREATE UNLOGGED" with TABLE, SEQUENCEorMATVIEW */`
	`3270`	`+/* Complete "CREATE UNLOGGED" with TABLEorSEQUENCE */`
`3271`	`3271`	`elseif (TailMatches("CREATE","UNLOGGED"))`
`3272`		`-{`
`3273`		`-/* but not MATVIEW in CREATE SCHEMA */`
`3274`		`-if (HeadMatches("CREATE","SCHEMA"))`
`3275`		`-COMPLETE_WITH("TABLE","SEQUENCE");`
`3276`		`-else`
`3277`		`-COMPLETE_WITH("TABLE","SEQUENCE","MATERIALIZED VIEW");`
`3278`		`-}`
	`3272`	`+COMPLETE_WITH("TABLE","SEQUENCE");`
`3279`	`3273`	`/* Complete PARTITION BY with RANGE ( or LIST ( or ... */`
`3280`	`3274`	`elseif (TailMatches("PARTITION","BY"))`
`3281`	`3275`	`COMPLETE_WITH("RANGE (","LIST (","HASH (");`

Comments

(0)