NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5b804cc

committed

Fix costing of parallel hash joins.

Commit1804284 established that single-batchparallel-aware hash joins could create one large shared hash table using thecombined work_mem budget of all participants. The costing accidentallyassumed that parallel-oblivious hash joins could also do that. Thedocumentation for initial_cost_hashjoin() also failed to mention the newargument. Repair.Author: Thomas MunroReported-By: Antonin HouskaReviewed-By: Antonin HouskaDiscussion:https://postgr.es/m/12441.1513935950%40localhost

1 parenta3739e3 commit5b804ccCopy full SHA for 5b804cc

File tree

2 files changed

-1

lines changed

src/backend/optimizer/path
- costsize.c
- joinpath.c

2 files changed

-1

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3143,6 +3143,8 @@ cached_scansel(PlannerInfo root, RestrictInfo rinfo, PathKey *pathkey)`
`3143`	`3143`	`* 'outer_path' is the outer input to the join`
`3144`	`3144`	`* 'inner_path' is the inner input to the join`
`3145`	`3145`	`* 'extra' contains miscellaneous information about the join`
	`3146`	`+ * 'parallel_hash' indicates that inner_path is partial and that a shared`
	`3147`	`+ *hash table will be built in parallel`
`3146`	`3148`	`*/`
`3147`	`3149`	`void`
`3148`	`3150`	`initial_cost_hashjoin(PlannerInforoot,JoinCostWorkspaceworkspace,`

`‎src/backend/optimizer/path/joinpath.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -814,7 +814,7 @@ try_partial_hashjoin_path(PlannerInfo *root,`
`814`	`814`	`* cost. Bail out right away if it looks terrible.`
`815`	`815`	`*/`
`816`	`816`	`initial_cost_hashjoin(root,&workspace,jointype,hashclauses,`
`817`		`-outer_path,inner_path,extra,true);`
	`817`	`+outer_path,inner_path,extra,parallel_hash);`
`818`	`818`	`if (!add_partial_path_precheck(joinrel,workspace.total_cost,NIL))`
`819`	`819`	`return;`
`820`	`820`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5b804cc

File tree

2 files changed

2 files changed

`‎src/backend/optimizer/path/costsize.c`

`‎src/backend/optimizer/path/joinpath.c`

0 commit comments