NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5af4456

committed

Fix thinko introduced in2bef06d et al.

The callers for GetOldestSafeDecodingTransactionId() all inverted theargument for the argument introduced in2bef06d. Luckily thisappears to be inconsequential for the moment, as we wait forconcurrent in-progress transaction when assembling asnapshot. Additionally this could only make a difference when adding asecond logical slot, because only a pre-existing slot could cause anissue by lowering the returned xid dangerously much.Reported-By: Antonin HouskaDiscussion:https://postgr.es/m/32704.1496993134@localhostBackport: 9.4-, where2bef06d was backpatched to.

1 parent0d1f98b commit5af4456Copy full SHA for 5af4456

File tree

2 files changed

-2

lines changed

src/backend/replication/logical
- logical.c
- snapbuild.c

2 files changed

-2

lines changed

`‎src/backend/replication/logical/logical.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ CreateInitDecodingContext(char *plugin,`
`288`	`288`	`*/`
`289`	`289`	`LWLockAcquire(ProcArrayLock,LW_EXCLUSIVE);`
`290`	`290`
`291`		`-xmin_horizon=GetOldestSafeDecodingTransactionId(need_full_snapshot);`
	`291`	`+xmin_horizon=GetOldestSafeDecodingTransactionId(!need_full_snapshot);`
`292`	`292`
`293`	`293`	`slot->effective_catalog_xmin=xmin_horizon;`
`294`	`294`	`slot->data.catalog_xmin=xmin_horizon;`

`‎src/backend/replication/logical/snapbuild.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -574,7 +574,7 @@ SnapBuildInitialSnapshot(SnapBuild *builder)`
`574`	`574`	`TransactionIdsafeXid;`
`575`	`575`
`576`	`576`	`LWLockAcquire(ProcArrayLock,LW_SHARED);`
`577`		`-safeXid=GetOldestSafeDecodingTransactionId(true);`
	`577`	`+safeXid=GetOldestSafeDecodingTransactionId(false);`
`578`	`578`	`LWLockRelease(ProcArrayLock);`
`579`	`579`
`580`	`580`	`Assert(TransactionIdPrecedesOrEquals(safeXid,snap->xmin));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5af4456

File tree

2 files changed

2 files changed

`‎src/backend/replication/logical/logical.c`

`‎src/backend/replication/logical/snapbuild.c`

0 commit comments