NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5a90740

committed

Update HINT for pre-existing shared memory block.

One should almost always terminate an old process, not use a manualremoval tool like ipcrm. Removal of the ipcclean script eleven yearsago (39627b1) and its non-replacementcorroborate that manual shm removal is now a niche goal. Back-patch to9.4 (all supported versions).Reviewed by Daniel Gustafsson and Kyotaro HORIGUCHI.Discussion:https://postgr.es/m/20180812064815.GB2301738@rfd.leadboat.com

1 parentbfbcad4 commit5a90740Copy full SHA for 5a90740

File tree

1 file changed

-7

lines changed

src/backend/utils/init
- miscinit.c

1 file changed

-7

lines changed

`‎src/backend/utils/init/miscinit.c`

Lines changed: 3 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -1066,14 +1066,10 @@ CreateLockFile(const char *filename, bool amPostmaster,`
`1066`	`1066`	`if (PGSharedMemoryIsInUse(id1,id2))`
`1067`	`1067`	`ereport(FATAL,`
`1068`	`1068`	`(errcode(ERRCODE_LOCK_FILE_EXISTS),`
`1069`		`-errmsg("pre-existing shared memory block "`
`1070`		`-"(key %lu, ID %lu) is still in use",`
	`1069`	`+errmsg("pre-existing shared memory block (key %lu, ID %lu) is still in use",`
`1071`	`1070`	`id1,id2),`
`1072`		`-errhint("If you're sure there are no old "`
`1073`		`-"server processes still running, remove "`
`1074`		`-"the shared memory block "`
`1075`		`-"or just delete the file \"%s\".",`
`1076`		`-filename)));`
	`1071`	`+errhint("Terminate any old server processes associated with data directory \"%s\".",`
	`1072`	`+refName)));`
`1077`	`1073`	`}`
`1078`	`1074`	`}`
`1079`	`1075`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5a90740

File tree

1 file changed

1 file changed

`‎src/backend/utils/init/miscinit.c`

0 commit comments