NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5a6eea0

committed

Add missing check_collation_set call to bpcharne().

We should throw an error for indeterminate collation, but bpcharne()was missing that logic, resulting in a much less user-friendly error(either an assertion failure or "cache lookup failed for collation 0").Per report from Manuel Rigger. Back-patch to v12 where the mistakecame in, evidently in commit5e1963f. (Before non-deterministiccollations, this function wasn't collation sensitive.)Discussion:https://postgr.es/m/CA+u7OA4HOjtymxAbuGNh4-X_2R0Lw5n01tzvP8E5-i-2gQXYWA@mail.gmail.com

1 parent99cc47b commit5a6eea0Copy full SHA for 5a6eea0

File tree

1 file changed

-0

lines changed

src/backend/utils/adt
- varchar.c

1 file changed

-0

lines changed

`‎src/backend/utils/adt/varchar.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -785,6 +785,8 @@ bpcharne(PG_FUNCTION_ARGS)`
`785`	`785`	`boolresult;`
`786`	`786`	`Oidcollid=PG_GET_COLLATION();`
`787`	`787`
	`788`	`+check_collation_set(collid);`
	`789`	`+`
`788`	`790`	`len1=bcTruelen(arg1);`
`789`	`791`	`len2=bcTruelen(arg2);`
`790`	`792`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5a6eea0

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/varchar.c`

0 commit comments