NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit598f303

committed

Fix bogus time printout in walreceiver's debug log messages.

The displayed sendtime and receipttime were always exactly equal, becausesomebody forgot that timestamptz_to_str returns a static buffer (therebysimplifying life for most callers, at the cost of complicating it for thosewho need two results concurrently). Apply the same pstrdup solution usedby the other call sites with this issue. Back-patch to 9.2 where thefaulty code was introduced. Per bug #9849 from Haruka Takatsuka, thoughthis is not exactly his patch.Possibly we should change timestamptz_to_str's API, but I wouldn't wantto do so in the back branches.

1 parenta2f9572 commit598f303Copy full SHA for 598f303

File tree

1 file changed

+12

-2

lines changed

src/backend/replication
- walreceiver.c

1 file changed

+12

-2

lines changed

`‎src/backend/replication/walreceiver.c`

Lines changed: 12 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1196,9 +1196,19 @@ ProcessWalSndrMessage(XLogRecPtr walEnd, TimestampTz sendTime)`
`1196`	`1196`	`SpinLockRelease(&walrcv->mutex);`
`1197`	`1197`
`1198`	`1198`	`if (log_min_messages <=DEBUG2)`
	`1199`	`+{`
	`1200`	`+char*sendtime;`
	`1201`	`+char*receipttime;`
	`1202`	`+`
	`1203`	`+/* Copy because timestamptz_to_str returns a static buffer */`
	`1204`	`+sendtime=pstrdup(timestamptz_to_str(sendTime));`
	`1205`	`+receipttime=pstrdup(timestamptz_to_str(lastMsgReceiptTime));`
`1199`	`1206`	`elog(DEBUG2,"sendtime %s receipttime %s replication apply delay %d ms transfer latency %d ms",`
`1200`		`-timestamptz_to_str(sendTime),`
`1201`		`-timestamptz_to_str(lastMsgReceiptTime),`
	`1207`	`+sendtime,`
	`1208`	`+receipttime,`
`1202`	`1209`	`GetReplicationApplyDelay(),`
`1203`	`1210`	`GetReplicationTransferLatency());`
	`1211`	`+pfree(sendtime);`
	`1212`	`+pfree(receipttime);`
	`1213`	`+}`
`1204`	`1214`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit598f303

File tree

1 file changed

1 file changed

`‎src/backend/replication/walreceiver.c`

0 commit comments