NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit594e61a

committed

Change some test macros to return true booleans

These macros work fine when they are used directly in an "if" test orsimilar, but as soon as the return values are assigned to booleanvariables (or passed as boolean arguments to some function), they becomebugs, hopefully caught by compiler warnings. To avoid future problems,fix the definitions so that they return actual booleans.To further minimize the risk that somebody uses them in back-patchedfixes that only work correctly in branches starting from the currentmaster and not in old ones, back-patch the change to supported branchesas appropriate.See also commitaf4472b, and the longdiscussion (and larger patch) in the thread mentioned in its commitmessage.Discussion:https://postgr.es/m/18672.1483022414@sss.pgh.pa.us

1 parentd00ca33 commit594e61aCopy full SHA for 594e61a

File tree

1 file changed

-5

lines changed

src/include/access
- htup_details.h

1 file changed

-5

lines changed

`‎src/include/access/htup_details.h`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,8 @@ struct HeapTupleHeaderData`
`237`	`237`	`*/`
`238`	`238`	`#defineHEAP_LOCKED_UPGRADED(infomask) \`
`239`	`239`	`( \`
`240`		`- ((infomask) & HEAP_XMAX_IS_MULTI) && \`
`241`		`- ((infomask) & HEAP_XMAX_LOCK_ONLY) && \`
	`240`	`+ ((infomask) & HEAP_XMAX_IS_MULTI)!= 0&& \`
	`241`	`+ ((infomask) & HEAP_XMAX_LOCK_ONLY)!= 0&& \`
`242`	`242`	`(((infomask) & (HEAP_XMAX_EXCL_LOCK \| HEAP_XMAX_KEYSHR_LOCK)) == 0) \`
`243`	`243`	`)`
`244`	`244`
`@@ -317,7 +317,7 @@ struct HeapTupleHeaderData`
`317`	`317`
`318`	`318`	`#defineHeapTupleHeaderXminCommitted(tup) \`
`319`	`319`	`( \`
`320`		`-(tup)->t_infomask & HEAP_XMIN_COMMITTED \`
	`320`	`+((tup)->t_infomask & HEAP_XMIN_COMMITTED) != 0 \`
`321`	`321`	`)`
`322`	`322`
`323`	`323`	`#defineHeapTupleHeaderXminInvalid(tup) \`
`@@ -501,7 +501,7 @@ do { \`
`501`	`501`
`502`	`502`	`#defineHeapTupleHeaderIsHeapOnly(tup) \`
`503`	`503`	`( \`
`504`		`- (tup)->t_infomask2 & HEAP_ONLY_TUPLE \`
	`504`	`+ ((tup)->t_infomask2 & HEAP_ONLY_TUPLE) != 0 \`
`505`	`505`	`)`
`506`	`506`
`507`	`507`	`#defineHeapTupleHeaderSetHeapOnly(tup) \`
`@@ -516,7 +516,7 @@ do { \`
`516`	`516`
`517`	`517`	`#defineHeapTupleHeaderHasMatch(tup) \`
`518`	`518`	`( \`
`519`		`- (tup)->t_infomask2 & HEAP_TUPLE_HAS_MATCH \`
	`519`	`+ ((tup)->t_infomask2 & HEAP_TUPLE_HAS_MATCH) != 0 \`
`520`	`520`	`)`
`521`	`521`
`522`	`522`	`#defineHeapTupleHeaderSetMatch(tup) \`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit594e61a

File tree

1 file changed

1 file changed

`‎src/include/access/htup_details.h`

0 commit comments