Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5945501

Browse files
committed
Remember asking for feedback during walsender shutdown.
Since5a991ef we're explicitly asking for feedback from the receivingside when shutting down walsender, if there's not yet replicateddata.Unfortunately we didn't remember (i.e. set waiting_for_ping_response totrue) having asked for feedback, leading to scenarios in which replieswere requested at a high frequency.I can't reproduce this problem on my laptop, I think that's because theproblem requires a significant TCP window to manifest due to the!pq_is_send_pending() condition. But since this clearly is a bug, let'sfix it. There's quite possibly more wrong than just this though.While fiddling with WalSndDone(), I rewrote a hard to understand commentabout looking at the flush vs. the write position.Reported-By: Nick Cleaton, Magnus HaganderAuthor: Nick CleatonDiscussion: CAFgz3kus=rC_avEgBV=+hRK5HYJ8vXskJRh8yEAbahJGTzF2VQ@mail.gmail.com CABUevExsjROqDcD0A2rnJ6HK6FuKGyewJr3PL12pw85BHFGS2Q@mail.gmail.comBackpatch: 9.4, were5a991ef introduced the use of feedback messages during shutdown.
1 parent23b09e1 commit5945501

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

‎src/backend/replication/walsender.c

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2487,13 +2487,14 @@ WalSndDone(WalSndSendDataCallback send_data)
24872487
send_data();
24882488

24892489
/*
2490-
*Check a write location to seewhether alltheWALhave successfully
2491-
*been replicated ifthis walsender is connecting to a standby such as
2492-
*pg_receivexlog which always returnsan invalid flush location.
2493-
*Otherwise, check a flushlocation.
2490+
*To figure outwhether all WALhas successfully been replicated, check
2491+
*flush location ifvalid, write otherwise. Tools like pg_receivexlog
2492+
*will usually (unless in synchronous mode) returnan invalid flush
2493+
* location.
24942494
*/
24952495
replicatedPtr=XLogRecPtrIsInvalid(MyWalSnd->flush) ?
24962496
MyWalSnd->write :MyWalSnd->flush;
2497+
24972498
if (WalSndCaughtUp&&sentPtr==replicatedPtr&&
24982499
!pq_is_send_pending())
24992500
{
@@ -2504,7 +2505,10 @@ WalSndDone(WalSndSendDataCallback send_data)
25042505
proc_exit(0);
25052506
}
25062507
if (!waiting_for_ping_response)
2508+
{
25072509
WalSndKeepalive(true);
2510+
waiting_for_ping_response= true;
2511+
}
25082512
}
25092513

25102514
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp