Commit59348fb

Amit Kapila

committed

Fix the check to limit sync workers.

We don't allow to invoke more sync workers once we have reached the syncworker limit per subscription. But the check to enforce this also doesn'tallow to launch an apply worker if it gets restarted.This code was introduced by commitde43897 but we caught the problemonly with the test added by recent commitc91f71b which started failingoccasionally in the buildfarm.As per buildfarm.Diagnosed-by: Amit Kapila, Masahiko Sawada, Tomas VondraAuthor: Amit KapilaBackpatch-through: 10Discussion:https://postgr.es/m/CAH2L28vddB_NFdRVpuyRBJEBWjz4BSyTB=_ektNRH8NJ1jf95g@mail.gmail.com https://postgr.es/m/f90d2b03-4462-ce95-a524-d91464e797c8@enterprisedb.com

1 parent0795da8 commit59348fbCopy full SHA for 59348fb

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -372,11 +372,11 @@ logicalrep_worker_launch(Oid dbid, Oid subid, const char *subname, Oid userid,`
`372`	`372`	`}`
`373`	`373`
`374`	`374`	`/*`
`375`		`- *If we reached thesyncworker limit per subscription, just exit`
`376`		`- *silently as we might get here because of an otherwise harmless race`
`377`		`- * condition.`
	`375`	`+ *We don't allow to invoke moresyncworkers once we have reached the sync`
	`376`	`+ *worker limit per subscription. So, just return silently as we might get`
	`377`	`+ *here because of an otherwise harmless racecondition.`
`378`	`378`	`*/`
`379`		`-if (nsyncworkers >=max_sync_workers_per_subscription)`
	`379`	`+if (OidIsValid(relid)&&nsyncworkers >=max_sync_workers_per_subscription)`
`380`	`380`	`{`
`381`	`381`	`LWLockRelease(LogicalRepWorkerLock);`
`382`	`382`	`return;`

Comments

(0)