Commit590a075

committed

Avoid criticizable perl code

Using `require` / `->import` instead of `use` avoids the use of a"stringy eval", making for cleaner code that we don't need to silenceperlcritic about.Per Andrew DunstanDiscussion:https://postgr.es/m/7cd3bbbd-0216-4436-d571-8f80c9259a07@dunslane.net

1 parentd00a4ad commit590a075Copy full SHA for 590a075

File tree

-8

lines changed

-8

lines changed

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,16 +9,16 @@`
`9`	`9`	`use Test::More;`
`10`	`10`
`11`	`11`	`# Use Test::Differences if installed, and select unified diff output.`
`12`		`-# No decent way to select a context line count with this;`
`13`		`-# we could use a sub ref to allow that.`
`14`	`12`	`BEGIN`
`15`	`13`	`{`
`16`		`-#<<< protect next line from pgperltidy`
`17`		`-if (!evalq{ use Test::Differences; unified_diff(); 1})## no critic (ProhibitStringyEval)`
`18`		`-#>>>`
`19`		`-{`
`20`		`-*eq_or_diff = \&is;`
`21`		`-}`
	`14`	`+eval {`
	`15`	`+require Test::Differences;`
	`16`	`+Test::Differences->import;`
	`17`	`+unified_diff();`
	`18`	`+};`
	`19`	`+`
	`20`	`+# No dice -- fall back to 'is'`
	`21`	`+*eq_or_diff = \&isif$@;`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`my$node = PostgreSQL::Test::Cluster->new('main');`

Comments

(0)