Commit58efabd

committed

Review wording on tablespaces w.r.t. partitioned tables

Remove a redundant comment, and document pg_class.reltablespace properlyin catalogs.sgml.After commitsa36c84c,8725958 and others.Backpatch to 12.Discussion:https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql

1 parentf3e4581 commit58efabdCopy full SHA for 58efabd

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1750,9 +1750,12 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l`
`1750`	`1750`	`<entry><type>oid</type></entry>`
`1751`	`1751`	`<entry><literal><link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.oid</literal></entry>`
`1752`	`1752`	`<entry>`
`1753`		`- The tablespace in which this relation is stored. If zero,`
`1754`		`- the database's default tablespace is implied. (Not meaningful`
`1755`		`- if the relation has no on-disk file.)`
	`1753`	`+ The tablespace in which this relation is stored.`
	`1754`	`+ If zero, the database's default tablespace is implied.`
	`1755`	`+ Not meaningful if the relation has no on-disk file,`
	`1756`	`+ except for partitioned tables, where this is the tablespace`
	`1757`	`+ in which partitions will be created when one is not`
	`1758`	`+ specified in the creation command.`
`1756`	`1759`	`</entry>`
`1757`	`1760`	`</row>`
`1758`	`1761`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -695,10 +695,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`695`	`695`	`}`
`696`	`696`	`else if (stmt->partbound)`
`697`	`697`	`{`
`698`		`-/*`
`699`		`- * For partitions, when no other tablespace is specified, we default`
`700`		`- * the tablespace to the parent partitioned table's.`
`701`		`- */`
`702`	`698`	`Assert(list_length(inheritOids) == 1);`
`703`	`699`	`tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));`
`704`	`700`	`}`

Comments

(0)