NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit58bc481

committed

Avoid "variable might be clobbered by longjmp" warning.

On older-model gcc, the original coding of UTILITY_BEGIN_QUERY() candraw this error because of multiple assignments to _needCleanup.Rather than mark that variable volatile, we can suppress the warningby arranging to have just one unconditional assignment before PG_TRY.

1 parent473ab40 commit58bc481Copy full SHA for 58bc481

File tree

1 file changed

-5

lines changed

src/backend/tcop
- utility.c

1 file changed

-5

lines changed

`‎src/backend/tcop/utility.c`

Lines changed: 2 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -380,12 +380,9 @@ ProcessUtility(Node *parsetree,`
`380`	`380`	`*/`
`381`	`381`	`#defineUTILITY_BEGIN_QUERY(isComplete) \`
`382`	`382`	`do { \`
`383`		`-bool_needCleanup = false; \`
	`383`	`+bool_needCleanup; \`
`384`	`384`	`\`
`385`		`-if (isComplete) \`
`386`		`-{ \`
`387`		`-_needCleanup = EventTriggerBeginCompleteQuery(); \`
`388`		`-} \`
	`385`	`+_needCleanup = (isComplete) && EventTriggerBeginCompleteQuery(); \`
`389`	`386`	`\`
`390`	`387`	`PG_TRY(); \`
`391`	`388`	`{ \`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit58bc481

File tree

1 file changed

1 file changed

`‎src/backend/tcop/utility.c`

0 commit comments