NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit58b2cf0

committed

Fix off-by-one error in Assertion.

The point of the assertion is to ensure that the arrays allocated in stackare large enough, but the check was one item short.This won't matter in practice because MaxIndexTuplesPerPage is anoverestimate, so you can't have that many items on a page in reality.But let's be tidy.Spotted by Anastasia Lubennikova. Backpatch to all supported versions, likethe patch that added the assertion.

1 parent97ff2a5 commit58b2cf0Copy full SHA for 58b2cf0

File tree

1 file changed

-1

lines changed

src/backend/storage/page
- bufpage.c

1 file changed

-1

lines changed

`‎src/backend/storage/page/bufpage.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -722,7 +722,7 @@ PageIndexMultiDelete(Page page, OffsetNumber *itemnos, int nitems)`
`722`	`722`	`intnextitm;`
`723`	`723`	`OffsetNumberoffnum;`
`724`	`724`
`725`		`-Assert(nitems<MaxIndexTuplesPerPage);`
	`725`	`+Assert(nitems <=MaxIndexTuplesPerPage);`
`726`	`726`
`727`	`727`	`/*`
`728`	`728`	`* If there aren't very many items to delete, then retail`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit58b2cf0

File tree

1 file changed

1 file changed

`‎src/backend/storage/page/bufpage.c`

0 commit comments