NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit588f50f

committed

Don't assume that PageIsEmpty() returns true on an all-zeros page.

It does currently, and I don't see us changing that any time soon, but wedon't make that assumption anywhere else.Per Tom Lane's suggestion. Backpatch to 9.2, like the previous patch thatadded this assumption.

1 parentbafe3b0 commit588f50fCopy full SHA for 588f50f

File tree

1 file changed

-1

lines changed

src/backend/access/spgist
- spgvacuum.c

1 file changed

-1

lines changed

`‎src/backend/access/spgist/spgvacuum.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -653,7 +653,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)`
`653`	`653`	`*/`
`654`	`654`	`if (!SpGistBlockIsRoot(blkno))`
`655`	`655`	`{`
`656`		`-if (PageIsEmpty(page))`
	`656`	`+if (PageIsNew(page)\|\|PageIsEmpty(page))`
`657`	`657`	`{`
`658`	`658`	`RecordFreeIndexPage(index,blkno);`
`659`	`659`	`bds->stats->pages_deleted++;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit588f50f

File tree

1 file changed

1 file changed

`‎src/backend/access/spgist/spgvacuum.c`

0 commit comments