Commit584f818

committed

Declare LWLock pointers as volatile to prevent AIX compiler from

reordering operations at its whim. Releasing TAS lock before we'vefinished updating proc structure is uncool.

1 parent53016fa commit584f818Copy full SHA for 584f818

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`* Portions Copyright (c) 1994, Regents of the University of California`
`16`	`16`	`*`
`17`	`17`	`* IDENTIFICATION`
`18`		`- * $Header: /cvsroot/pgsql/src/backend/storage/lmgr/lwlock.c,v 1.3 2001/11/05 17:46:28 momjian Exp $`
	`18`	`+ * $Header: /cvsroot/pgsql/src/backend/storage/lmgr/lwlock.c,v 1.4 2001/12/10 21:13:50 tgl Exp $`
`19`	`19`	`*`
`20`	`20`	`*-------------------------------------------------------------------------`
`21`	`21`	`*/`
`@@ -185,7 +185,7 @@ LWLockAssign(void)`
`185`	`185`	`void`
`186`	`186`	`LWLockAcquire(LWLockIdlockid,LWLockModemode)`
`187`	`187`	`{`
`188`		`-LWLock*lock=LWLockArray+lockid;`
	`188`	`+volatileLWLock*lock=LWLockArray+lockid;`
`189`	`189`	`boolmustwait;`
`190`	`190`
`191`	`191`	`PRINT_LWDEBUG("LWLockAcquire",lockid,lock);`
`@@ -303,7 +303,7 @@ LWLockAcquire(LWLockId lockid, LWLockMode mode)`
`303`	`303`	`bool`
`304`	`304`	`LWLockConditionalAcquire(LWLockIdlockid,LWLockModemode)`
`305`	`305`	`{`
`306`		`-LWLock*lock=LWLockArray+lockid;`
	`306`	`+volatileLWLock*lock=LWLockArray+lockid;`
`307`	`307`	`boolmustwait;`
`308`	`308`
`309`	`309`	`PRINT_LWDEBUG("LWLockConditionalAcquire",lockid,lock);`
`@@ -369,7 +369,7 @@ LWLockConditionalAcquire(LWLockId lockid, LWLockMode mode)`
`369`	`369`	`void`
`370`	`370`	`LWLockRelease(LWLockIdlockid)`
`371`	`371`	`{`
`372`		`-LWLock*lock=LWLockArray+lockid;`
	`372`	`+volatileLWLock*lock=LWLockArray+lockid;`
`373`	`373`	`PROC*head;`
`374`	`374`	`PROC*proc;`
`375`	`375`	`inti;`

Comments

(0)