NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit583e15a

committed

Fix places in TestLib.pm in need of adaptation to the output of Msys perl

Contrary to the output of native perl, Msys perl generates outputs withCRLFs characters. There are already places in the TAP code where CRLFs(\r\n) are automatically converted to LF (\n) on Msys, but we missed acouple of places when running commands and using their output forcomparison, that would lead to failures.This problem has been found thanks to the test added in5adb067 usingTestLib::command_checks_all(), but after a closer look more code pathswere missing a filter.This is backpatched all the way down to prevent any surprises if a newtest is introduced in stable branches.Reviewed-by: Andrew Dunstan, Álvaro HerreraDiscussion:https://postgr.es/m/1252480.1631829409@sss.pgh.pa.usBackpatch-through: 9.6

1 parent5f0a073 commit583e15aCopy full SHA for 583e15a

File tree

1 file changed

-0

lines changed

src/test/perl
- TestLib.pm

1 file changed

-0

lines changed

`‎src/test/perl/TestLib.pm`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -377,6 +377,7 @@ sub run_command`
`377`	`377`	`my ($cmd) =@_;`
`378`	`378`	`my ($stdout,$stderr);`
`379`	`379`	`my$result = IPC::Run::run$cmd,'>', \$stdout,'2>', \$stderr;`
	`380`	`+foreach ($stderr,$stdout) {s/\r\n/\n/gif$Config{osname}eq'msys'; }`
`380`	`381`	`chomp($stdout);`
`381`	`382`	`chomp($stderr);`
`382`	`383`	`return ($stdout,$stderr);`
`@@ -787,6 +788,7 @@ sub command_like`
`787`	`788`	`my$result = IPC::Run::run$cmd,'>', \$stdout,'2>', \$stderr;`
`788`	`789`	`ok($result,"$test_name: exit code 0");`
`789`	`790`	`is($stderr,'',"$test_name: no stderr");`
	`791`	`+$stdout =~s/\r\n/\n/gif$Config{osname}eq'msys';`
`790`	`792`	`like($stdout,$expected_stdout,"$test_name: matches");`
`791`	`793`	`return;`
`792`	`794`	`}`
`@@ -839,6 +841,7 @@ sub command_fails_like`
`839`	`841`	`print("# Running:" .join("", @{$cmd}) ."\n");`
`840`	`842`	`my$result = IPC::Run::run$cmd,'>', \$stdout,'2>', \$stderr;`
`841`	`843`	`ok(!$result,"$test_name: exit code not 0");`
	`844`	`+$stderr =~s/\r\n/\n/gif$Config{osname}eq'msys';`
`842`	`845`	`like($stderr,$expected_stderr,"$test_name: matches");`
`843`	`846`	`return;`
`844`	`847`	`}`
`@@ -883,6 +886,8 @@ sub command_checks_all`
`883`	`886`	`if$ret & 127;`
`884`	`887`	`$ret =$ret >> 8;`
`885`	`888`
	`889`	`+foreach ($stderr,$stdout) {s/\r\n/\n/gif$Config{osname}eq'msys'; }`
	`890`	`+`
`886`	`891`	`# check status`
`887`	`892`	`ok($ret ==$expected_ret,`
`888`	`893`	`"$test_name status (got$ret vs expected$expected_ret)");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit583e15a

File tree

1 file changed

1 file changed

`‎src/test/perl/TestLib.pm`

0 commit comments