forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit583025c
committed
Fix thinko in construction of old_conpfeqop list.
This should lappend the OIDs, not lcons them; the existing code produceda list in reversed order. This is harmless for single-key FKs or FKswhere all the key columns are of the same type, which probably explainshow it went unnoticed. But if those conditions are not met,ATAddForeignKeyConstraint would make the wrong decision about whether anexisting FK needs to be revalidated. I think it would almost always errin the safe direction by revalidating a constraint that didn't need it.You could imagine scenarios where the pfeqop check was fooled byswapping the types of two FK columns in one ALTER TABLE, but that casewould probably be rejected by other tests, so it might be impossible toget to the worst-case scenario where an FK should be revalidated andisn't. (And even then, it's likely to be fine, unless there are weirdinconsistencies in the equality behavior of the replacement types.)However, this is a performance bug at least.Noted while poking around to see whether lcons calls could be convertedto lappend.This bug is old, dating to commitcb3a7c2, so back-patch to allsupported branches.1 parentf68060c commit583025c
1 file changed
+1
-2
lines changedLines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7382 | 7382 | | |
7383 | 7383 | | |
7384 | 7384 | | |
7385 | | - | |
7386 | 7385 | | |
7387 | 7386 | | |
7388 | 7387 | | |
| |||
9911 | 9910 | | |
9912 | 9911 | | |
9913 | 9912 | | |
9914 | | - | |
| 9913 | + | |
9915 | 9914 | | |
9916 | 9915 | | |
9917 | 9916 | | |
| |||
0 commit comments
Comments
(0)