NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit58193c5

committed

Paranoia about unordered comparisons in IEEE float math. If we are

given values that compare as unordered, make sure we reply that theyare equal, which is better than giving an arbitrary answer --- at leastit doesn't depend on which one is passed as which arg.

1 parentfc7c16f commit58193c5Copy full SHA for 58193c5

File tree

1 file changed

-7

lines changed

src/backend/utils/adt
- float.c

1 file changed

-7

lines changed

`‎src/backend/utils/adt/float.c`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/float.c,v 1.71 2001/05/03 19:00:36 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/float.c,v 1.72 2001/06/02 17:12:12 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -566,10 +566,10 @@ float4_cmp_internal(float4 a, float4 b)`
`566`	`566`	`{`
`567`	`567`	`if (a>b)`
`568`	`568`	`return1;`
`569`		`-elseif (a==b)`
`570`		`-return0;`
`571`		`-else`
	`569`	`+elseif (a<b)`
`572`	`570`	`return-1;`
	`571`	`+else`
	`572`	`+return0;`
`573`	`573`	`}`
`574`	`574`	`}`
`575`	`575`
`@@ -662,10 +662,10 @@ float8_cmp_internal(float8 a, float8 b)`
`662`	`662`	`{`
`663`	`663`	`if (a>b)`
`664`	`664`	`return1;`
`665`		`-elseif (a==b)`
`666`		`-return0;`
`667`		`-else`
	`665`	`+elseif (a<b)`
`668`	`666`	`return-1;`
	`667`	`+else`
	`668`	`+return0;`
`669`	`669`	`}`
`670`	`670`	`}`
`671`	`671`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit58193c5

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/float.c`

0 commit comments