Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit57bdf29

Browse files
committed
Fix potential memory leak in pgcrypto
When allocating a EVP context, it would have been possible to leak somememory allocated directly by OpenSSL, that PostgreSQL lost track of ifthe initialization of the context allocated failed. The cleanup can bedone with EVP_MD_CTX_destroy().Note that EVP APIs exist since OpenSSL 0.9.7 and we have in the treeequivalent implementations for older versions sincece9b75d (coderemoved with9b7cd59 as of 10~). However, in 9.5 and 9.6, the existingcode makes use of EVP_MD_CTX_destroy() and EVP_MD_CTX_create() withoutan equivalent implementation when building the tree with OpenSSL 0.9.6or older, meaning that this code is in reality broken with such versionssince it got introduced ine2838c5. As we have heard no complains aboutthat, it does not seem worth bothering with in 9.5 and 9.6, so I haveleft that out for simplicity.Author: Michael PaquierDiscussion:https://postgr.es/m/20201015072212.GC2305@paquier.xyzBackpatch-through: 9.5
1 parent3753e27 commit57bdf29

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

‎contrib/pgcrypto/openssl.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ px_find_digest(const char *name, PX_MD **res)
203203
}
204204
if (EVP_DigestInit_ex(ctx,md,NULL)==0)
205205
{
206+
EVP_MD_CTX_destroy(ctx);
206207
pfree(digest);
207208
return-1;
208209
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp