NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit579b72c

committed

Run AC_PROG_GCC_TRADITIONAL only when running AC_PROG_CC,

ie, not when user specifies --with-CC. This corrects a scripting errorthat I'm surprised hasn't been reported more often. Moving the macro callto the earlier point in the script is correct anyway: if -traditional is needed,it should get added to CFLAGS before we start using the compiler forother tests.

1 parent9e38dcf commit579b72cCopy full SHA for 579b72c

File tree

1 file changed

-4

lines changed

src
- configure.in

1 file changed

-4

lines changed

`‎src/configure.in`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,10 @@ AC_ARG_WITH(CC,`
`335`	`335`	`esac`
`336`	`336`	`CC="$withval"`
`337`	`337`	`],`
`338`		`- [ AC_PROG_CC])`
	`338`	`+ [`
	`339`	`+AC_PROG_CC`
	`340`	`+AC_PROG_GCC_TRADITIONAL`
	`341`	`+])`
`339`	`342`
`340`	`343`	`if test "$CC" = "gcc"`
`341`	`344`	`then`
`@@ -346,11 +349,9 @@ fi`
`346`	`349`	`AC_SUBST(CC_VERSION)`
`347`	`350`
`348`	`351`	`CPPFLAGS="$CPPFLAGS $PGSQL_CPPFLAGS"`
`349`		`-export CPPFLAGS`
`350`	`352`	`echo "- setting CPPFLAGS=$CPPFLAGS"`
`351`	`353`
`352`	`354`	`LDFLAGS="$LDFLAGS $PGSQL_LDFLAGS"`
`353`		`-export LDFLAGS`
`354`	`355`	`echo "- setting LDFLAGS=$LDFLAGS"`
`355`	`356`
`356`	`357`	`dnl Checks for programs.`
`@@ -668,7 +669,6 @@ main() {`
`668`	`669`	`AC_MSG_RESULT(assuming not on target machine))`
`669`	`670`
`670`	`671`	`dnl Checks for library functions.`
`671`		`-AC_PROG_GCC_TRADITIONAL`
`672`	`672`	`AC_FUNC_MEMCMP`
`673`	`673`	`AC_TYPE_SIGNAL`
`674`	`674`	`AC_FUNC_VPRINTF`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit579b72c

File tree

1 file changed

1 file changed

`‎src/configure.in`

0 commit comments