Commit576bb0f

committed

When using the WAL-logged CREATE DATABASE strategy, bulk extend.

This should improve performance, and was suggested by Andres Freund.Back-patch to v15 to keep the code consistent across branches.Dilip KumarDiscussion:http://postgr.es/m/C3458199-FEDD-4356-865A-08DFAA5D4065@anarazel.deDiscussion:http://postgr.es/m/CAFiTN-sJ0vVpJrZ=R5M+g7Tr8=NN4wKOtrqOcDEsfFfnZgivVA@mail.gmail.com

1 parent9c4c22f commit576bb0fCopy full SHA for 576bb0f

File tree

+10

-1

lines changed

+10

-1

lines changed

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3713,6 +3713,7 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode,`
`3713`	`3713`	`booluse_wal;`
`3714`	`3714`	`BlockNumbernblocks;`
`3715`	`3715`	`BlockNumberblkno;`
	`3716`	`+PGAlignedBlockbuf;`
`3716`	`3717`	`BufferAccessStrategybstrategy_src;`
`3717`	`3718`	`BufferAccessStrategybstrategy_dst;`
`3718`	`3719`
`@@ -3731,6 +3732,14 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode,`
`3731`	`3732`	`if (nblocks==0)`
`3732`	`3733`	`return;`
`3733`	`3734`
	`3735`	`+/*`
	`3736`	`+ * Bulk extend the destination relation of the same size as the source`
	`3737`	`+ * relation before starting to copy block by block.`
	`3738`	`+ */`
	`3739`	`+memset(buf.data,0,BLCKSZ);`
	`3740`	`+smgrextend(smgropen(dstnode,InvalidBackendId),forkNum,nblocks-1,`
	`3741`	`+buf.data, true);`
	`3742`	`+`
`3734`	`3743`	`/* This is a bulk operation, so use buffer access strategies. */`
`3735`	`3744`	`bstrategy_src=GetAccessStrategy(BAS_BULKREAD);`
`3736`	`3745`	`bstrategy_dst=GetAccessStrategy(BAS_BULKWRITE);`
`@@ -3748,7 +3757,7 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode,`
`3748`	`3757`	`srcPage=BufferGetPage(srcBuf);`
`3749`	`3758`
`3750`	`3759`	`/* Use P_NEW to extend the destination relation. */`
`3751`		`-dstBuf=ReadBufferWithoutRelcache(dstnode,forkNum,P_NEW,`
	`3760`	`+dstBuf=ReadBufferWithoutRelcache(dstnode,forkNum,blkno,`
`3752`	`3761`	`RBM_NORMAL,bstrategy_dst,`
`3753`	`3762`	`permanent);`
`3754`	`3763`	`LockBuffer(dstBuf,BUFFER_LOCK_EXCLUSIVE);`

Comments

(0)