NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5747f68

committed

Fix query checking consistency of table amhandlers in opr_sanity.sql

As written, the query checked for an access method of type 's', which isnot an AM type supported in the core code.Error introduced by8586bf7. As this query is not checking what itshould, backpatch all the way down.Reviewed-by: Aleksander AlekseevDiscussion:https://postgr.es/m/ZVxJkAJrKbfHETiy@paquier.xyzBackpatch-through: 12

1 parent1e468ea commit5747f68Copy full SHA for 5747f68

File tree

2 files changed

-2

lines changed

src/test/regress
- expected
  - opr_sanity.out
- sql
  - opr_sanity.sql

2 files changed

-2

lines changed

`‎src/test/regress/expected/opr_sanity.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1903,7 +1903,7 @@ WHERE p2.oid = p1.amhandler AND p1.amtype = 'i' AND`
`1903`	`1903`	`-- Check for table amhandler functions with the wrong signature`
`1904`	`1904`	`SELECT p1.oid, p1.amname, p2.oid, p2.proname`
`1905`	`1905`	`FROM pg_am AS p1, pg_proc AS p2`
`1906`		`-WHERE p2.oid = p1.amhandler AND p1.amtype = 's' AND`
	`1906`	`+WHERE p2.oid = p1.amhandler AND p1.amtype = 't' AND`
`1907`	`1907`	`(p2.prorettype != 'table_am_handler'::regtype`
`1908`	`1908`	`OR p2.proretset`
`1909`	`1909`	`OR p2.pronargs != 1`

`‎src/test/regress/sql/opr_sanity.sql`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1244,7 +1244,7 @@ WHERE p2.oid = p1.amhandler AND p1.amtype = 'i' AND`
`1244`	`1244`
`1245`	`1245`	`SELECTp1.oid,p1.amname,p2.oid,p2.proname`
`1246`	`1246`	`FROM pg_amAS p1, pg_procAS p2`
`1247`		`-WHEREp2.oid=p1.amhandlerANDp1.amtype='s'AND`
	`1247`	`+WHEREp2.oid=p1.amhandlerANDp1.amtype='t'AND`
`1248`	`1248`	`(p2.prorettype!='table_am_handler'::regtype`
`1249`	`1249`	`ORp2.proretset`
`1250`	`1250`	`ORp2.pronargs!=1`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5747f68

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/opr_sanity.out`

`‎src/test/regress/sql/opr_sanity.sql`

0 commit comments