Commit573aaa5

committed

NATURAL CROSS JOIN is a contradiction in terms, not to mention disallowed

by the SQL spec and by our parser. Thanks to Jonathan Scott for findingthis longstanding error.

1 parent97c7cb0 commit573aaa5Copy full SHA for 573aaa5

File tree

-9

lines changed

-9

lines changed

Lines changed: 4 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*back to source text`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.164 2004/05/05 04:48:46 tgl Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.165 2004/05/07 03:19:44 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -3788,14 +3788,9 @@ get_from_clause_item(Node jtnode, Query query, deparse_context *context)`
`3788`	`3788`	`switch (j->jointype)`
`3789`	`3789`	`{`
`3790`	`3790`	`caseJOIN_INNER:`
`3791`		`-if (j->quals)`
`3792`		`-appendContextKeyword(context,"NATURAL JOIN ",`
`3793`		`--PRETTYINDENT_JOIN,`
`3794`		`-PRETTYINDENT_JOIN,0);`
`3795`		`-else`
`3796`		`-appendContextKeyword(context,"NATURAL CROSS JOIN ",`
`3797`		`--PRETTYINDENT_JOIN,`
`3798`		`-PRETTYINDENT_JOIN,0);`
	`3791`	`+appendContextKeyword(context,"NATURAL JOIN ",`
	`3792`	`+-PRETTYINDENT_JOIN,`
	`3793`	`+PRETTYINDENT_JOIN,0);`
`3799`	`3794`	`break;`
`3800`	`3795`	`caseJOIN_LEFT:`
`3801`	`3796`	`appendContextKeyword(context,"NATURAL LEFT JOIN ",`

Comments

(0)