Commit572695b

Etsuro Fujita

committed

Correct error message for row-level triggers with transition tables on partitioned tables.

"Triggers on partitioned tables cannot have transition tables." isincorrect as we allow statement-level triggers on partitioned tables tohave transition tables.This has been wrong since commit86f5759; back-patch to v11 where thatcommit came in.Reviewed by Tom Lane.Discussion:https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

1 parentab70b3a commit572695bCopy full SHA for 572695b

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ CreateTriggerFiringOn(CreateTrigStmt stmt, const char queryString,`
`263`	`263`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`264`	`264`	`errmsg("\"%s\" is a partitioned table",`
`265`	`265`	`RelationGetRelationName(rel)),`
`266`		`-errdetail("Triggers on partitionedtablescannot have transition tables.")));`
	`266`	`+errdetail("ROW triggers with transitiontablesare not supported on partitioned tables.")));`
`267`	`267`	`}`
`268`	`268`	`}`
`269`	`269`	`elseif (rel->rd_rel->relkind==RELKIND_VIEW)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2024,7 +2024,7 @@ create trigger failed after update on parted_trig`
`2024`	`2024`	`referencing old table as old_table`
`2025`	`2025`	`for each row execute procedure trigger_nothing();`
`2026`	`2026`	`ERROR: "parted_trig" is a partitioned table`
`2027`		`-DETAIL:Triggers on partitionedtablescannot have transition tables.`
	`2027`	`+DETAIL:ROW triggers with transitiontablesare not supported on partitioned tables.`
`2028`	`2028`	`drop table parted_trig;`
`2029`	`2029`	`--`
`2030`	`2030`	`-- Verify trigger creation for partitioned tables, and drop behavior`

Comments

(0)