forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit56d0ed3
committed
Give better hints for ambiguous or unreferenceable columns.
Examine ParseNamespaceItem flags to detect whether a column nameis unreferenceable for lack of LATERAL, or could be referenced ifa qualified name were used, and give better hints for such cases.Also, don't phrase the message to imply that there's only onematching column when there is really more than one.Many of the regression test output changes are not very interesting,but just reflect reclassifying the "There is a column ... but itcannot be referenced from this part of the query" messages as DETAILrather than HINT. They are details per our style guide, in the senseof being factual rather than offering advice; and this change providesroom to offer actual HINTs about what to do.While here, adjust the fuzzy-name-matching code to be a shade lessimpenetrable. It was overloading the meanings of FuzzyAttrMatchStatefields way too much IMO, so splitting them into multiple fields seemsto make it clearer. It's not like we need to shave bytes in thatstruct.Per discussion of bug #17233 from Alexander Korolev.Discussion:https://postgr.es/m/17233-afb9d806aaa64b17@postgresql.org1 parent9c6ad5e commit56d0ed3
File tree
7 files changed
+233
-106
lines changed- src
- backend/parser
- test/regress
- expected
- sql
7 files changed
+233
-106
lines changed0 commit comments
Comments
(0)