NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit564ce62

committed

Rename "hash_mem" local variable.

The term "hash_mem" will take on new significance when pending work toadd a new hash_mem_multiplier GUC is committed. Rename a local variablethat happens to have been called hash_mem now to avoid confusion.

1 parent1e0dfd1 commit564ce62Copy full SHA for 564ce62

File tree

1 file changed

-4

lines changed

src/backend/executor
- nodeAgg.c

1 file changed

-4

lines changed

`‎src/backend/executor/nodeAgg.c`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1896,7 +1896,7 @@ static void`
`1896`	`1896`	`hash_agg_update_metrics(AggState*aggstate,boolfrom_tape,intnpartitions)`
`1897`	`1897`	`{`
`1898`	`1898`	`Sizemeta_mem;`
`1899`		`-Sizehash_mem;`
	`1899`	`+Sizehashkey_mem;`
`1900`	`1900`	`Sizebuffer_mem;`
`1901`	`1901`	`Sizetotal_mem;`
`1902`	`1902`
`@@ -1908,15 +1908,15 @@ hash_agg_update_metrics(AggState *aggstate, bool from_tape, int npartitions)`
`1908`	`1908`	`meta_mem=MemoryContextMemAllocated(aggstate->hash_metacxt, true);`
`1909`	`1909`
`1910`	`1910`	`/* memory for the group keys and transition states */`
`1911`		`-hash_mem=MemoryContextMemAllocated(aggstate->hashcontext->ecxt_per_tuple_memory, true);`
	`1911`	`+hashkey_mem=MemoryContextMemAllocated(aggstate->hashcontext->ecxt_per_tuple_memory, true);`
`1912`	`1912`
`1913`	`1913`	`/* memory for read/write tape buffers, if spilled */`
`1914`	`1914`	`buffer_mem=npartitions*HASHAGG_WRITE_BUFFER_SIZE;`
`1915`	`1915`	`if (from_tape)`
`1916`	`1916`	`buffer_mem+=HASHAGG_READ_BUFFER_SIZE;`
`1917`	`1917`
`1918`	`1918`	`/* update peak mem */`
`1919`		`-total_mem=meta_mem+hash_mem+buffer_mem;`
	`1919`	`+total_mem=meta_mem+hashkey_mem+buffer_mem;`
`1920`	`1920`	`if (total_mem>aggstate->hash_mem_peak)`
`1921`	`1921`	`aggstate->hash_mem_peak=total_mem;`
`1922`	`1922`
`@@ -1934,7 +1934,7 @@ hash_agg_update_metrics(AggState *aggstate, bool from_tape, int npartitions)`
`1934`	`1934`	`{`
`1935`	`1935`	`aggstate->hashentrysize=`
`1936`	`1936`	`sizeof(TupleHashEntryData)+`
`1937`		`-(hash_mem / (double)aggstate->hash_ngroups_current);`
	`1937`	`+(hashkey_mem / (double)aggstate->hash_ngroups_current);`
`1938`	`1938`	`}`
`1939`	`1939`	`}`
`1940`	`1940`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit564ce62

File tree

1 file changed

1 file changed

`‎src/backend/executor/nodeAgg.c`

0 commit comments