NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit562bee0

committed

Don't truncate database and user names in startup packets.

Unlike commands such as CREATE DATABASE, ProcessStartupPacket()does not perform multibyte-aware truncation of overlength names.This means that connection attempts might fail even if the userprovides the same overlength names that were used in CREATEDATABASE, CREATE ROLE, etc. Ideally, we'd do the same multibyte-aware truncation in both code paths, but it doesn't seem worth theadded complexity of trying to discover the encoding of the names.Instead, let's simply skip truncating the names in the startuppacket and let the user/database lookup fail later on. With thischange, users must provide the exact names stored in the catalogs,even if the names were truncated.This reverts commitd18c1d1.Author: Bertrand DrouvotReviewed-by: Kyotaro Horiguchi, Tom LaneDiscussion:https://postgr.es/m/07436793-1426-29b2-f924-db7422a05fb7%40gmail.com

1 parent29cf61a commit562bee0Copy full SHA for 562bee0

File tree

1 file changed

-9

lines changed

src/backend/postmaster
- postmaster.c

1 file changed

-9

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 0 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -2290,15 +2290,6 @@ ProcessStartupPacket(Port *port, bool ssl_done, bool gss_done)`
`2290`	`2290`	`}`
`2291`	`2291`	`}`
`2292`	`2292`
`2293`		`-/*`
`2294`		`- * Truncate given database and user names to length of a Postgres name.`
`2295`		`- * This avoids lookup failures when overlength names are given.`
`2296`		`- */`
`2297`		`-if (strlen(port->database_name) >=NAMEDATALEN)`
`2298`		`-port->database_name[NAMEDATALEN-1]='\0';`
`2299`		`-if (strlen(port->user_name) >=NAMEDATALEN)`
`2300`		`-port->user_name[NAMEDATALEN-1]='\0';`
`2301`		`-`
`2302`	`2293`	`if (am_walsender)`
`2303`	`2294`	`MyBackendType=B_WAL_SENDER;`
`2304`	`2295`	`else`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit562bee0

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/postmaster.c`

0 commit comments