NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit560bb56

committed

Fix memory leak and inefficiency in CREATE DATABASE ... STRATEGY WAL_LOG

RelationCopyStorageUsingBuffer() did not free the strategies used to accessthe source / target relation. They memory was released at the end of thetransaction, but when using a template database with a lot of relations, thetemporary leak can become big prohibitively big.RelationCopyStorageUsingBuffer() acquired the buffer for the target relationwith RBM_NORMAL, therefore requiring a read of a block guaranteed to bezero. Use RBM_ZERO_AND_LOCK instead.Reviewed-by: Robert Haas <robertmhaas@gmail.com>Discussion:https://postgr.es/m/20230321070113.o2vqqxogjykwgfrr@awork3.anarazel.deBackpatch: 15-, where STRATEGY WAL_LOG was introduced

1 parenta70e6e4 commit560bb56Copy full SHA for 560bb56

File tree

1 file changed

-3

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-3

lines changed

`‎src/backend/storage/buffer/bufmgr.c`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3756,11 +3756,9 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode,`
`3756`	`3756`	`LockBuffer(srcBuf,BUFFER_LOCK_SHARE);`
`3757`	`3757`	`srcPage=BufferGetPage(srcBuf);`
`3758`	`3758`
`3759`		`-/* Use P_NEW to extend the destination relation. */`
`3760`	`3759`	`dstBuf=ReadBufferWithoutRelcache(dstnode,forkNum,blkno,`
`3761`		`-RBM_NORMAL,bstrategy_dst,`
	`3760`	`+RBM_ZERO_AND_LOCK,bstrategy_dst,`
`3762`	`3761`	`permanent);`
`3763`		`-LockBuffer(dstBuf,BUFFER_LOCK_EXCLUSIVE);`
`3764`	`3762`	`dstPage=BufferGetPage(dstBuf);`
`3765`	`3763`
`3766`	`3764`	`START_CRIT_SECTION();`
`@@ -3778,6 +3776,9 @@ RelationCopyStorageUsingBuffer(RelFileNode srcnode,`
`3778`	`3776`	`UnlockReleaseBuffer(dstBuf);`
`3779`	`3777`	`UnlockReleaseBuffer(srcBuf);`
`3780`	`3778`	`}`
	`3779`	`+`
	`3780`	`+FreeAccessStrategy(bstrategy_src);`
	`3781`	`+FreeAccessStrategy(bstrategy_dst);`
`3781`	`3782`	`}`
`3782`	`3783`
`3783`	`3784`	`/* ---------------------------------------------------------------------`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit560bb56

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c`

0 commit comments