Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit558cf80

Browse files
committed
bufmgr: Fix undefined behaviour with, unrealistically, large temp_buffers
Quoting Melanie:> Since if buffer is INT_MAX, then the -(buffer + 1) version invokes> undefined behavior while the -buffer - 1 version doesn't.All other places were already using the correct version. I (Andres), copiedthe code into more places in a patch. Melanie caught it in review, but toprevent more people from copying the bad code, fix it. Even if it is atheoretical issue.We really ought to wrap these accesses in a helper function...As this is a theoretical issue, don't backpatch.Reported-by: Melanie Plageman <melanieplageman@gmail.com>Discussion:https://postgr.es/m/CAAKRu_aW2SX_LWtwHgfnqYpBrunMLfE9PD6-ioPpkh92XH0qpg@mail.gmail.com
1 parente9d202a commit558cf80

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/backend/storage/buffer/localbuf.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ MarkLocalBufferDirty(Buffer buffer)
305305
fprintf(stderr,"LB DIRTY %d\n",buffer);
306306
#endif
307307

308-
bufid=-(buffer+1);
308+
bufid=-buffer-1;
309309

310310
Assert(LocalRefCount[bufid]>0);
311311

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp