NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5515ec0

committed

Fix calculation of latency of pgbench backslash commands.

When we loop back to the top of doCustom after processing a backslashcommand, we must reset the "now" timestamp, because that's used tocalculate the time spent executing the previous command.Report and fix by Fabien Coelho. Backpatch to 9.5, where this was broken.

1 parenta293228 commit5515ec0Copy full SHA for 5515ec0

File tree

1 file changed

-2

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-2

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1135,11 +1135,12 @@ doCustom(TState thread, CState st, instr_time conn_time, FILE logfile, AggVa`
`1135`	`1135`	`* first time it's needed, and reuse the same value throughout this`
`1136`	`1136`	`* function after that. This also ensures that e.g. the calculated latency`
`1137`	`1137`	`* reported in the log file and in the totals are the same. Zero means`
`1138`		`- * "not set yet".`
	`1138`	`+ * "not set yet". Reset "now" when we step to the next command with "goto`
	`1139`	`+ * top", though.`
`1139`	`1140`	`*/`
	`1141`	`+top:`
`1140`	`1142`	`INSTR_TIME_SET_ZERO(now);`
`1141`	`1143`
`1142`		`-top:`
`1143`	`1144`	`commands=sql_files[st->use_file];`
`1144`	`1145`
`1145`	`1146`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5515ec0

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments