NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit54db0e5

committed

pg_upgrade: fix shutdown check for standby servers

Commit244142d only tested for thepg_controldata output for primary servers, but standby servers havedifferent "Database cluster state" output, so check for that too.Diagnosed-by: Michael PaquierDiscussion:https://postgr.es/m/20180810164240.GM13638@paquier.xyzBackpatch-through: 9.3

1 parent69de171 commit54db0e5Copy full SHA for 54db0e5

File tree

1 file changed

-1

lines changed

src/bin/pg_upgrade
- controldata.c

1 file changed

-1

lines changed

`‎src/bin/pg_upgrade/controldata.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,8 @@ get_control_data(ClusterInfo *cluster, bool live_check)`
`149`	`149`	`/* remove leading spaces */`
`150`	`150`	`while (*p==' ')`
`151`	`151`	`p++;`
`152`		`-if (strcmp(p,"shut down\n")!=0)`
	`152`	`+if (strcmp(p,"shut down\n")!=0&&`
	`153`	`+strcmp(p,"shut down in recovery\n")!=0)`
`153`	`154`	`{`
`154`	`155`	`if (cluster==&old_cluster)`
`155`	`156`	`pg_fatal("The source cluster was not shut down cleanly.\n");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit54db0e5

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/controldata.c`

0 commit comments