Commit54affb4

committed

Improve function header comment for create_singleton_array().

Mentioning the caller is neither future-proof nor an adequate substitutefor giving an API specification. Per gripe from Neha Khatri, thoughI changed the patch around some.Discussion:https://postgr.es/m/CAFO0U+_fS5SRhzq6uPG+4fbERhoA9N2+nPrtvaC9mmeWivxbsA@mail.gmail.com

1 parent92a43e4 commit54affb4Copy full SHA for 54affb4

File tree

-1

lines changed

-1

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,10 @@ array_cat(PG_FUNCTION_ARGS)`
`455`	`455`
`456`	`456`
`457`	`457`	`/*`
`458`		`- * used by text_to_array() in varlena.c`
	`458`	`+ * create_singleton_array - make a one-element array`
	`459`	`+ *`
	`460`	`+ * If desired, the caller can ask for it to be higher than one-dimensional.`
	`461`	`+ * Caller's fcinfo must be passed in, as we use fn_extra for caching.`
`459`	`462`	`*/`
`460`	`463`	`ArrayType*`
`461`	`464`	`create_singleton_array(FunctionCallInfofcinfo,`

Comments

(0)