Commit5485c99

committed

Fix silly nil-pointer-dereference bug introduced in commitd5f6f13.

Don't fetch record->xl_info before we've verified that record isn'tNULL. Per Coverity.Michael Paquier

1 parent32416b0 commit5485c99Copy full SHA for 5485c99

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7812,7 +7812,6 @@ ReadCheckpointRecord(XLogReaderState *xlogreader, XLogRecPtr RecPtr,`
`7812`	`7812`	`}`
`7813`	`7813`
`7814`	`7814`	`record=ReadRecord(xlogreader,RecPtr,LOG, true);`
`7815`		`-info=record->xl_info& ~XLR_INFO_MASK;`
`7816`	`7815`
`7817`	`7816`	`if (record==NULL)`
`7818`	`7817`	`{`
`@@ -7855,6 +7854,7 @@ ReadCheckpointRecord(XLogReaderState *xlogreader, XLogRecPtr RecPtr,`
`7855`	`7854`	`}`
`7856`	`7855`	`returnNULL;`
`7857`	`7856`	`}`
	`7857`	`+info=record->xl_info& ~XLR_INFO_MASK;`
`7858`	`7858`	`if (info!=XLOG_CHECKPOINT_SHUTDOWN&&`
`7859`	`7859`	`info!=XLOG_CHECKPOINT_ONLINE)`
`7860`	`7860`	`{`

Comments

(0)