NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5463319

committed

Dodge a compiler bug affecting timetz_zone/timetz_izone.

This avoids a compiler bug occurring in AIX's xlc, even in prettylate-model revisions. Buildfarm testing has now confirmed thatonly 64-bit xlc is affected. Although we are contemplatingdropping support for xlc in v17, it's still supported in theback branches, so we need this fix.Back-patch of code changes from HEAD commit19fa977.(The test cases were already back-patched, in4a427b8 et al.)Discussion:https://postgr.es/m/CA+hUKGK=DOC+hE-62FKfZy=Ybt5uLkrg3zCZD-jFykM-iPn8yw@mail.gmail.com

1 parentd568d2f commit5463319Copy full SHA for 5463319

File tree

1 file changed

-4

lines changed

src/backend/utils/adt
- date.c

1 file changed

-4

lines changed

`‎src/backend/utils/adt/date.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -3089,10 +3089,11 @@ timetz_zone(PG_FUNCTION_ARGS)`
`3089`	`3089`	`result= (TimeTzADT*)palloc(sizeof(TimeTzADT));`
`3090`	`3090`
`3091`	`3091`	`result->time=t->time+ (t->zone-tz)*USECS_PER_SEC;`
	`3092`	`+/* C99 modulo has the wrong sign convention for negative input */`
`3092`	`3093`	`while (result->time<INT64CONST(0))`
`3093`	`3094`	`result->time+=USECS_PER_DAY;`
`3094`		`-while (result->time >=USECS_PER_DAY)`
`3095`		`-result->time-=USECS_PER_DAY;`
	`3095`	`+if (result->time >=USECS_PER_DAY)`
	`3096`	`+result->time%=USECS_PER_DAY;`
`3096`	`3097`
`3097`	`3098`	`result->zone=tz;`
`3098`	`3099`
`@@ -3122,10 +3123,11 @@ timetz_izone(PG_FUNCTION_ARGS)`
`3122`	`3123`	`result= (TimeTzADT*)palloc(sizeof(TimeTzADT));`
`3123`	`3124`
`3124`	`3125`	`result->time=time->time+ (time->zone-tz)*USECS_PER_SEC;`
	`3126`	`+/* C99 modulo has the wrong sign convention for negative input */`
`3125`	`3127`	`while (result->time<INT64CONST(0))`
`3126`	`3128`	`result->time+=USECS_PER_DAY;`
`3127`		`-while (result->time >=USECS_PER_DAY)`
`3128`		`-result->time-=USECS_PER_DAY;`
	`3129`	`+if (result->time >=USECS_PER_DAY)`
	`3130`	`+result->time%=USECS_PER_DAY;`
`3129`	`3131`
`3130`	`3132`	`result->zone=tz;`
`3131`	`3133`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5463319

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/date.c`

0 commit comments