NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit54487d1

committed

Fix table dump in pg_dump[all] with backends older than 9.5

The access method name "amname" can be dumped as of3b925e9, butqueries for backends older than 9.5 forgot to map it to a dummy NULLvalue, causing the column to not be mapped to a number. As a result,pg_dump was throwing some spurious errors in its stderr output comingfrom libpq:pg_dump: column number -1 is out of range 0..36Fix this issue by adding a mapping of "amname" to NULL to all the olderqueries.Discussion:https://postgr.es/m/20190522083038.GA16837@paquier.xyzAuthor: Michael PaquierReviewed-by: Dmitry Dolgov, Andres Freund, Tom Lane

1 parentf916221 commit54487d1Copy full SHA for 54487d1

File tree

1 file changed

-0

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-0

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -6113,6 +6113,7 @@ getTables(Archive fout, int numTables)`
`6113`	`6113`	`"tc.relminmxid AS tminmxid, "`
`6114`	`6114`	`"c.relpersistence, c.relispopulated, "`
`6115`	`6115`	`"c.relreplident, c.relpages, "`
	`6116`	`+ "NULL AS amname, "`
`6116`	`6117`	`"CASE WHEN c.reloftype <> 0 THEN c.reloftype::pg_catalog.regtype ELSE NULL END AS reloftype, "`
`6117`	`6118`	`"d.refobjid AS owning_tab, "`
`6118`	`6119`	`"d.refobjsubid AS owning_col, "`
`@@ -6162,6 +6163,7 @@ getTables(Archive fout, int numTables)`
`6162`	`6163`	`"tc.relminmxid AS tminmxid, "`
`6163`	`6164`	`"c.relpersistence, c.relispopulated, "`
`6164`	`6165`	`"c.relreplident, c.relpages, "`
	`6166`	`+ "NULL AS amname, "`
`6165`	`6167`	`"CASE WHEN c.reloftype <> 0 THEN c.reloftype::pg_catalog.regtype ELSE NULL END AS reloftype, "`
`6166`	`6168`	`"d.refobjid AS owning_tab, "`
`6167`	`6169`	`"d.refobjsubid AS owning_col, "`
`@@ -6211,6 +6213,7 @@ getTables(Archive fout, int numTables)`
`6211`	`6213`	`"tc.relminmxid AS tminmxid, "`
`6212`	`6214`	`"c.relpersistence, c.relispopulated, "`
`6213`	`6215`	`"'d' AS relreplident, c.relpages, "`
	`6216`	`+ "NULL AS amname, "`
`6214`	`6217`	`"CASE WHEN c.reloftype <> 0 THEN c.reloftype::pg_catalog.regtype ELSE NULL END AS reloftype, "`
`6215`	`6218`	`"d.refobjid AS owning_tab, "`
`6216`	`6219`	`"d.refobjsubid AS owning_col, "`
`@@ -6260,6 +6263,7 @@ getTables(Archive fout, int numTables)`
`6260`	`6263`	`"0 AS tminmxid, "`
`6261`	`6264`	`"c.relpersistence, 't' as relispopulated, "`
`6262`	`6265`	`"'d' AS relreplident, c.relpages, "`
	`6266`	`+ "NULL AS amname, "`
`6263`	`6267`	`"CASE WHEN c.reloftype <> 0 THEN c.reloftype::pg_catalog.regtype ELSE NULL END AS reloftype, "`
`6264`	`6268`	`"d.refobjid AS owning_tab, "`
`6265`	`6269`	`"d.refobjsubid AS owning_col, "`
`@@ -6307,6 +6311,7 @@ getTables(Archive fout, int numTables)`
`6307`	`6311`	`"0 AS tminmxid, "`
`6308`	`6312`	`"'p' AS relpersistence, 't' as relispopulated, "`
`6309`	`6313`	`"'d' AS relreplident, c.relpages, "`
	`6314`	`+ "NULL AS amname, "`
`6310`	`6315`	`"CASE WHEN c.reloftype <> 0 THEN c.reloftype::pg_catalog.regtype ELSE NULL END AS reloftype, "`
`6311`	`6316`	`"d.refobjid AS owning_tab, "`
`6312`	`6317`	`"d.refobjsubid AS owning_col, "`
`@@ -6353,6 +6358,7 @@ getTables(Archive fout, int numTables)`
`6353`	`6358`	`"0 AS tminmxid, "`
`6354`	`6359`	`"'p' AS relpersistence, 't' as relispopulated, "`
`6355`	`6360`	`"'d' AS relreplident, c.relpages, "`
	`6361`	`+ "NULL AS amname, "`
`6356`	`6362`	`"NULL AS reloftype, "`
`6357`	`6363`	`"d.refobjid AS owning_tab, "`
`6358`	`6364`	`"d.refobjsubid AS owning_col, "`
`@@ -6399,6 +6405,7 @@ getTables(Archive fout, int numTables)`
`6399`	`6405`	`"0 AS tminmxid, "`
`6400`	`6406`	`"'p' AS relpersistence, 't' as relispopulated, "`
`6401`	`6407`	`"'d' AS relreplident, c.relpages, "`
	`6408`	`+ "NULL AS amname, "`
`6402`	`6409`	`"NULL AS reloftype, "`
`6403`	`6410`	`"d.refobjid AS owning_tab, "`
`6404`	`6411`	`"d.refobjsubid AS owning_col, "`
`@@ -6444,6 +6451,7 @@ getTables(Archive fout, int numTables)`
`6444`	`6451`	`"0 AS tfrozenxid, 0 AS tminmxid,"`
`6445`	`6452`	`"'p' AS relpersistence, 't' as relispopulated, "`
`6446`	`6453`	`"'d' AS relreplident, relpages, "`
	`6454`	`+ "NULL AS amname, "`
`6447`	`6455`	`"NULL AS reloftype, "`
`6448`	`6456`	`"d.refobjid AS owning_tab, "`
`6449`	`6457`	`"d.refobjsubid AS owning_col, "`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit54487d1

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments