Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit543e205

Browse files
committed
Fixmake installcheck for serializable transactions.
Commite5550d5 added some newtests for ALTER TABLE which involved table scans. Whendefault_transaction_isolation = 'serializable' these acquirerelation-level SIReadLocks. The test results didn't cope withthat. Add SIReadLock as the minimum lock level for purposes ofthese tests.This could also be fixed by excluding this type of lock from themy_locks view, but it would be a bug for SIReadLock to show up fora relation which was not otherwise locked, so do it this way toallow that sort of condition to cause a regression test failure.There is some question whether we could avoid taking SIReadLocksduring these operations, but confirming the safety of that andfiguring out how to avoid the locks is not trivial, and would bea separate patch.Backpatch to 9.4 where the new tests were added.
1 parent4d94b5f commit543e205

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

‎src/test/regress/expected/alter_table.out

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1837,7 +1837,8 @@ DROP TABLE check_fk_presence_1, check_fk_presence_2;
18371837
drop type lockmodes;
18381838
ERROR: type "lockmodes" does not exist
18391839
create type lockmodes as enum (
1840-
'AccessShareLock'
1840+
'SIReadLock'
1841+
,'AccessShareLock'
18411842
,'RowShareLock'
18421843
,'RowExclusiveLock'
18431844
,'ShareUpdateExclusiveLock'

‎src/test/regress/sql/alter_table.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1270,7 +1270,8 @@ DROP TABLE check_fk_presence_1, check_fk_presence_2;
12701270
--
12711271
droptype lockmodes;
12721272
createtypelockmodesas enum (
1273-
'AccessShareLock'
1273+
'SIReadLock'
1274+
,'AccessShareLock'
12741275
,'RowShareLock'
12751276
,'RowExclusiveLock'
12761277
,'ShareUpdateExclusiveLock'

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp