Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit5436cb3

Browse files
committed
Fix end LSN determination in recently added test
The test added in commite44dae0 has a thinko: it wants to readinfo about a few WAL records, but it obtains the LSN of the final recordto read by asking for the WAL insert position; however,pg_get_wal_records_info only accepts to read up to the flush position(cf. IsFutureLSN()). In normal conditions there is no difference, sincethe last record written by the preceding loop is known flushed and it'sthe one the test wants; but it's possible to have some other processinsert another WAL record that isn't flushed, and that causes the wholetest to explode.Fix by having pg_get_wal_records_info() read only up to the flushedposition. Backpatch to 15, which is where pg_walinspect appeared.Author: Karina Litskevich <litskevichkarina@gmail.com>Discussion:https://postgr.es/m/a5559c95-52c3-5eea-cd63-9b4f1c70ff96@gmail.com
1 parent2655ecd commit5436cb3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/test/modules/brin/t/02_wal_consistency.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
end
6161
$$;
6262
});
63-
my$end_lsn =$whiskey->lsn('insert');
63+
my$end_lsn =$whiskey->lsn('flush');
6464

6565
my ($ret,$out,$err) =$whiskey->psql(
6666
'postgres',qq{

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp