NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5423853

committed

Avoid retrieval of CHECK constraints and DEFAULT exprs in data-only dump

Those extra queries are not necessary when doing a data-only dump. Withthis change, this means that the dependencies between CHECK/DEFAULT andthe parent table are not tracked anymore for a data-only dump. However,these dependencies are only used for the schema generation and we havenever guaranteed that a dump can be reloaded if a CHECK constraint usesa custom function whose behavior changes when loading the data, likewhen using cross-table references in the CHECK function.Author: Julien RouhaudReviewed-by: Daniel Gustafsson, Michael PaquierDiscussion:https://postgr.es/m/20200712054850.GA92357@nol

1 parentc8aeaf3 commit5423853Copy full SHA for 5423853

File tree

1 file changed

-4

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-4

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -8644,9 +8644,10 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8644`	`8644`	`PQclear(res);`
`8645`	`8645`
`8646`	`8646`	`/*`
`8647`		`- * Get info about column defaults`
	`8647`	`+ * Get info about column defaults. This is skipped for a data-only`
	`8648`	`+ * dump, as it is only needed for table schemas.`
`8648`	`8649`	`*/`
`8649`		`-if (hasdefaults)`
	`8650`	`+if (!dopt->dataOnly &&hasdefaults)`
`8650`	`8651`	`{`
`8651`	`8652`	`AttrDefInfo *attrdefs;`
`8652`	`8653`	`intnumDefaults;`
`@@ -8731,9 +8732,10 @@ getTableAttrs(Archive fout, TableInfo tblinfo, int numTables)`
`8731`	`8732`	`}`
`8732`	`8733`
`8733`	`8734`	`/*`
`8734`		`- * Get info about table CHECK constraints`
	`8735`	`+ * Get info about table CHECK constraints. This is skipped for a`
	`8736`	`+ * data-only dump, as it is only needed for table schemas.`
`8735`	`8737`	`*/`
`8736`		`-if (tbinfo->ncheck > 0)`
	`8738`	`+if (!dopt->dataOnly &&tbinfo->ncheck > 0)`
`8737`	`8739`	`{`
`8738`	`8740`	`ConstraintInfo *constrs;`
`8739`	`8741`	`intnumConstrs;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5423853

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments