NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit53ea2b7

committed

Don't use _BitScanForward64/_BitScanReverse64 on 32-bit MSVC builds

6773197 added support for making use of MSVC's bit scanning functions.However, that commit failed to consider 32-bit MSVC builds where the64-bit versions of these functions are unavailable. This resulted incompilation failures on 32-bit MSVC.Here we adjust the code so we fall back on the manual way of finding thebit positions for 64-bit integers when building on 32-bit MSVC.Bug: #17967Reported-by: Youmiu MoDiscussion:https://postgr.es/m/17967-cd21e34a314141b2@postgresql.org

1 parentf245236 commit53ea2b7Copy full SHA for 53ea2b7

File tree

1 file changed

-2

lines changed

src/include/port
- pg_bitutils.h

1 file changed

-2

lines changed

`‎src/include/port/pg_bitutils.h`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ pg_leftmost_one_pos64(uint64 word)`
`81`	`81`	`#error must have a working 64-bit integer datatype`
`82`	`82`	`#endif/* HAVE_LONG_INT_64 */`
`83`	`83`
`84`		`-#elif defined(_MSC_VER)`
	`84`	`+#elif defined(_MSC_VER)&& (defined(_M_AMD64)\|\| defined(_M_ARM64))`
`85`	`85`	`unsigned longresult;`
`86`	`86`	`boolnon_zero;`
`87`	`87`
`@@ -152,7 +152,7 @@ pg_rightmost_one_pos64(uint64 word)`
`152`	`152`	`#error must have a working 64-bit integer datatype`
`153`	`153`	`#endif/* HAVE_LONG_INT_64 */`
`154`	`154`
`155`		`-#elif defined(_MSC_VER)`
	`155`	`+#elif defined(_MSC_VER)&& (defined(_M_AMD64)\|\| defined(_M_ARM64))`
`156`	`156`	`unsigned longresult;`
`157`	`157`	`boolnon_zero;`
`158`	`158`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit53ea2b7

File tree

1 file changed

1 file changed

`‎src/include/port/pg_bitutils.h`

0 commit comments