NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit53aafdb

committed

Strip file names reported in error messages on Windows, too.

Commitdd13605 established a policy that error message FILE itemsshould include only the base name of the reporting source file, foruniformity and succinctness. We now observe that some Windows compilersuse backslashes in __FILE__ strings, so truncate at backslashes as well.This is expected to fix some platform variation in the results of thenew libpq_pipeline test module.Discussion:https://postgr.es/m/3650140.1617372290@sss.pgh.pa.us

1 parent1877c9a commit53aafdbCopy full SHA for 53aafdb

File tree

1 file changed

-0

lines changed

src/backend/utils/error
- elog.c

1 file changed

-0

lines changed

`‎src/backend/utils/error/elog.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -529,6 +529,10 @@ errfinish(const char filename, int lineno, const char funcname)`
`529`	`529`	`slash=strrchr(filename,'/');`
`530`	`530`	`if (slash)`
`531`	`531`	`filename=slash+1;`
	`532`	`+/* Some Windows compilers use backslashes in __FILE__ strings */`
	`533`	`+slash=strrchr(filename,'\\');`
	`534`	`+if (slash)`
	`535`	`+filename=slash+1;`
`532`	`536`	`}`
`533`	`537`
`534`	`538`	`edata->filename=filename;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit53aafdb

File tree

1 file changed

1 file changed

`‎src/backend/utils/error/elog.c`

0 commit comments