Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5396b18

Browse files
committed
Remove expensive test of postgres_fdw batch inserts
The test inserted 70k rows into a foreign table, in order to verifycorrect behavior with more than 65535 parameters, and was added inresponse to a bug report.However, this is rather expensive, especially when running the testsunder valgrind, CLOBBER_CACHE_ALWAYS etc. It doesn't seem worth it tokeep running the test, so remove it from all branches (14+).Backpatch-through: 14Discussion:https://postgr.es/m/2131017.1623451468@sss.pgh.pa.us
1 parent8d3e171 commit5396b18

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

‎contrib/postgres_fdw/expected/postgres_fdw.out

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9991,17 +9991,6 @@ SELECT COUNT(*) FROM ftable;
99919991
34
99929992
(1 row)
99939993

9994-
TRUNCATE batch_table;
9995-
DROP FOREIGN TABLE ftable;
9996-
-- try if large batches exceed max number of bind parameters
9997-
CREATE FOREIGN TABLE ftable ( x int ) SERVER loopback OPTIONS ( table_name 'batch_table', batch_size '100000' );
9998-
INSERT INTO ftable SELECT * FROM generate_series(1, 70000) i;
9999-
SELECT COUNT(*) FROM ftable;
10000-
count
10001-
-------
10002-
70000
10003-
(1 row)
10004-
100059994
TRUNCATE batch_table;
100069995
DROP FOREIGN TABLE ftable;
100079996
-- Disable batch insert

‎contrib/postgres_fdw/sql/postgres_fdw.sql

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3125,13 +3125,6 @@ SELECT COUNT(*) FROM ftable;
31253125
TRUNCATE batch_table;
31263126
DROP FOREIGN TABLE ftable;
31273127

3128-
-- try if large batches exceed max number of bind parameters
3129-
CREATE FOREIGN TABLE ftable ( xint ) SERVER loopback OPTIONS ( table_name'batch_table', batch_size'100000' );
3130-
INSERT INTO ftableSELECT*FROM generate_series(1,70000) i;
3131-
SELECTCOUNT(*)FROM ftable;
3132-
TRUNCATE batch_table;
3133-
DROP FOREIGN TABLE ftable;
3134-
31353128
-- Disable batch insert
31363129
CREATE FOREIGN TABLE ftable ( xint ) SERVER loopback OPTIONS ( table_name'batch_table', batch_size'1' );
31373130
EXPLAIN (VERBOSE, COSTS OFF)INSERT INTO ftableVALUES (1), (2);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp