NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5380719

committed

Fix memory leak with lower, upper and initcap with ICU-provided collations

The leak happens in str_tolower, str_toupper and str_initcap, which areused in several places including their equivalent SQL-level functions,and can only be triggered when using an ICU-provided collation whenconverting the input string.b615920 fixed a similar leak. Backpatch down 10 where ICU collationshave been introduced.Author: Konstantin KnizhnikDiscussion:https://postgr.es/m/94c0ad0a-cbc2-e4a3-7829-2bdeaf9146db@postgrespro.ruBackpatch-through: 10

1 parentaad0926 commit5380719Copy full SHA for 5380719

File tree

1 file changed

-0

lines changed

src/backend/utils/adt
- formatting.c

1 file changed

-0

lines changed

`‎src/backend/utils/adt/formatting.c‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1586,6 +1586,7 @@ str_tolower(const char *buff, size_t nbytes, Oid collid)`
`1586`	`1586`	`&buff_conv,buff_uchar,len_uchar);`
`1587`	`1587`	`icu_from_uchar(&result,buff_conv,len_conv);`
`1588`	`1588`	`pfree(buff_uchar);`
	`1589`	`+pfree(buff_conv);`
`1589`	`1590`	`}`
`1590`	`1591`	`else`
`1591`	`1592`	`#endif`
`@@ -1709,6 +1710,7 @@ str_toupper(const char *buff, size_t nbytes, Oid collid)`
`1709`	`1710`	`&buff_conv,buff_uchar,len_uchar);`
`1710`	`1711`	`icu_from_uchar(&result,buff_conv,len_conv);`
`1711`	`1712`	`pfree(buff_uchar);`
	`1713`	`+pfree(buff_conv);`
`1712`	`1714`	`}`
`1713`	`1715`	`else`
`1714`	`1716`	`#endif`
`@@ -1833,6 +1835,7 @@ str_initcap(const char *buff, size_t nbytes, Oid collid)`
`1833`	`1835`	`&buff_conv,buff_uchar,len_uchar);`
`1834`	`1836`	`icu_from_uchar(&result,buff_conv,len_conv);`
`1835`	`1837`	`pfree(buff_uchar);`
	`1838`	`+pfree(buff_conv);`
`1836`	`1839`	`}`
`1837`	`1840`	`else`
`1838`	`1841`	`#endif`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5380719

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/formatting.c‎`

0 commit comments