forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit537b266
committed
Fix syslogger's rotation disable/re-enable logic.
If it fails to open a new log file, the syslogger assumes there's somethingwrong with its parameters (such as log_directory), and stops attemptingautomatic time-based or size-based log file rotations. Sending it SIGHUPis supposed to start that up again. However, the original coding for thatwas really bogus, involving clobbering a couple of GUC variables and hopingthat SIGHUP processing would restore them. Get rid of that technique infavor of maintaining a separate flag showing we've turned rotation off.Per report from Mark Kirkwood.Also, the syslogger will automatically attempt to create the log_directorydirectory if it doesn't exist, but that was only happening at startup.For consistency and ease of use, it should do the same whenever the valueof log_directory is changed by SIGHUP.Back-patch to all supported branches.1 parent3424bff commit537b266
1 file changed
+20
-6
lines changedLines changed: 20 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
88 | 88 |
| |
89 | 89 |
| |
90 | 90 |
| |
| 91 | + | |
91 | 92 |
| |
92 | 93 |
| |
93 | 94 |
| |
| |||
318 | 319 |
| |
319 | 320 |
| |
320 | 321 |
| |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
321 | 327 |
| |
322 | 328 |
| |
323 | 329 |
| |
| |||
335 | 341 |
| |
336 | 342 |
| |
337 | 343 |
| |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
338 | 354 |
| |
339 | 355 |
| |
340 |
| - | |
| 356 | + | |
341 | 357 |
| |
342 | 358 |
| |
343 | 359 |
| |
| |||
346 | 362 |
| |
347 | 363 |
| |
348 | 364 |
| |
349 |
| - | |
| 365 | + | |
350 | 366 |
| |
351 | 367 |
| |
352 | 368 |
| |
| |||
1122 | 1138 |
| |
1123 | 1139 |
| |
1124 | 1140 |
| |
1125 |
| - | |
1126 |
| - | |
| 1141 | + | |
1127 | 1142 |
| |
1128 | 1143 |
| |
1129 | 1144 |
| |
| |||
1167 | 1182 |
| |
1168 | 1183 |
| |
1169 | 1184 |
| |
1170 |
| - | |
1171 |
| - | |
| 1185 | + | |
1172 | 1186 |
| |
1173 | 1187 |
| |
1174 | 1188 |
| |
|
0 commit comments
Comments
(0)