Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit52b6364

Browse files
committed
Code review for commitdc203dc.
Remove duplicate assignment. This part by Ashutosh Bapat.Remove now-obsolete comment. This part by me, although the pendingjoin pushdown patch does something similar, and for the same reason:there's no reason to keep two lists of the things in the fdw_privatestructure that have to be kept in sync with each other.
1 parentf2305d4 commit52b6364

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

‎contrib/postgres_fdw/postgres_fdw.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,6 @@ PG_MODULE_MAGIC;
5353
/*
5454
* Indexes of FDW-private information stored in fdw_private lists.
5555
*
56-
* We store various information in ForeignScan.fdw_private to pass it from
57-
* planner to executor. Currently we store:
58-
*
59-
* 1) SELECT statement text to be sent to the remote server
60-
* 2) Integer list of attribute numbers retrieved by the SELECT
61-
*
6256
* These items are indexed with the enum FdwScanPrivateIndex, so an item
6357
* can be fetched with list_nth(). For example, to get the SELECT statement:
6458
*sql = strVal(list_nth(fdw_private, FdwScanPrivateSelectSql));
@@ -1016,8 +1010,6 @@ postgresGetForeignPlan(PlannerInfo *root,
10161010
* Build the fdw_private list that will be available to the executor.
10171011
* Items in the list must match enum FdwScanPrivateIndex, above.
10181012
*/
1019-
fdw_private=list_make2(makeString(sql.data),
1020-
retrieved_attrs);
10211013
fdw_private=list_make3(makeString(sql.data),
10221014
retrieved_attrs,
10231015
makeInteger(fpinfo->fetch_size));

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp