forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit52377bb
committed
Revert "Add TAP test to automate the equivalent of check_guc"
This reverts commitb0a55f4, to remove for now the TAP test that did theequivalent of check_guc. The test has been using pg_config --sharedirto find the location of postgresql.conf.sample. While the buildfarm andnormal build environments rather liked that, this proves to be an issuefor Debian where pg_config is patched to not be relocatable, causing thetest to fail.Rather than relying on pg_config, we'd better find the sample file basedon its location from the source directory. However, this is also anissue as a TAP test only offers the build directory as of TESTDIR in theenvironment context, so this would fail with VPATH builds. Perhaps thesource path could be provided additionally when running the TAP tests.Or perhaps we may be able to get away by just switching to a SQLapproach, by using PG_ABS_SRCDIR but this is going to require some extraloops to get the sample file from the correct path in src/backend/. Inany case, this needs more thoughts, so just revert the test case untilsomething better is done about this relocation problem.Reported-by: Christopher BergDiscussion:https://postgr.es/m/YgYw25OXV5men8Fj@msg.df7cb.de1 parentefa4a94 commit52377bb
1 file changed
+0
-110
lines changedLines changed: 0 additions & 110 deletions
This file was deleted.
0 commit comments
Comments
(0)