Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5232872

Browse files
committed
Prevent sharing transition states between ordered-set aggregates.
This ought to work, but the built-in OSAs are not capable of coping,because their final-functions destructively modify their transitionstate (specifically, the contained tuplesort object). That was finewhen those functions were written, but commit804163b moved thegoalposts without telling orderedsetaggs.c.We should fix the built-in OSAs to support this, but it will takea little work, especially if we don't want to sacrifice performancein the normal non-shared-state case. Given that it took a year after9.6 release for anyone to notice this bug, we should not prioritizesharable-state over nonsharable-state performance. And a proper fixis likely to be more complicated than we'd want to back-patch, too.Therefore, let's just put in this stop-gap patch to prevent nodeAgg.cfrom choosing to use shared state for OSAs. We can revert it in HEADwhen we get a better fix.Report from Lukas Eder, diagnosis by me, patch by David Rowley.Back-patch to 9.6 where the problem was introduced.Discussion:https://postgr.es/m/CAB4ELO5RZhOamuT9Xsf72ozbenDLLXZKSk07FiSVsuJNZB861A@mail.gmail.com
1 parent36b4b91 commit5232872

File tree

3 files changed

+40
-0
lines changed

3 files changed

+40
-0
lines changed

‎src/backend/executor/nodeAgg.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3808,6 +3808,16 @@ find_compatible_pertrans(AggState *aggstate, Aggref *newagg,
38083808
{
38093809
ListCell*lc;
38103810

3811+
/*
3812+
* For the moment, never try to share transition states between different
3813+
* ordered-set aggregates. This is necessary because the finalfns of the
3814+
* built-in OSAs (see orderedsetaggs.c) are destructive of their
3815+
* transition states. We should fix them so we can allow this, but not
3816+
* losing performance in the normal non-shared case will take some work.
3817+
*/
3818+
if (AGGKIND_IS_ORDERED_SET(newagg->aggkind))
3819+
return-1;
3820+
38113821
foreach(lc,transnos)
38123822
{
38133823
inttransno=lfirst_int(lc);

‎src/test/regress/expected/aggregates.out

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1860,6 +1860,25 @@ NOTICE: avg_transfn called with 3
18601860
2 | 6
18611861
(1 row)
18621862

1863+
-- ideally these would share state, but we have to fix the OSAs first.
1864+
select
1865+
percentile_cont(0.5) within group (order by a),
1866+
percentile_disc(0.5) within group (order by a)
1867+
from (values(1::float8),(3),(5),(7)) t(a);
1868+
percentile_cont | percentile_disc
1869+
-----------------+-----------------
1870+
4 | 3
1871+
(1 row)
1872+
1873+
select
1874+
rank(4) within group (order by a),
1875+
dense_rank(4) within group (order by a)
1876+
from (values(1),(3),(5),(7)) t(a);
1877+
rank | dense_rank
1878+
------+------------
1879+
3 | 3
1880+
(1 row)
1881+
18631882
-- test that aggs with the same sfunc and initcond share the same agg state
18641883
create aggregate my_sum_init(int4)
18651884
(

‎src/test/regress/sql/aggregates.sql

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,17 @@ select my_avg(one) filter (where one > 1),my_sum(one) from (values(1),(3)) t(one
739739
-- this should not share the state due to different input columns.
740740
select my_avg(one),my_sum(two)from (values(1,2),(3,4)) t(one,two);
741741

742+
-- ideally these would share state, but we have to fix the OSAs first.
743+
select
744+
percentile_cont(0.5) within group (order by a),
745+
percentile_disc(0.5) within group (order by a)
746+
from (values(1::float8),(3),(5),(7)) t(a);
747+
748+
select
749+
rank(4) within group (order by a),
750+
dense_rank(4) within group (order by a)
751+
from (values(1),(3),(5),(7)) t(a);
752+
742753
-- test that aggs with the same sfunc and initcond share the same agg state
743754
createaggregatemy_sum_init(int4)
744755
(

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp