Commit520e7af

committed

Review wording on tablespaces w.r.t. partitioned tables

Remove a redundant comment, and document pg_class.reltablespace properlyin catalogs.sgml.After commitsa36c84c,8725958 and others.Backpatch to 12.Discussion:https://postgr.es/m/202403191013.w2kr7wqlamqz@alvherre.pgsql

1 parent992189a commit520e7afCopy full SHA for 520e7af

File tree

-7

lines changed

-7

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1948,9 +1948,12 @@ SCRAM-SHA-256$<replaceable><iteration count></replaceable>:<replaceable>&l`
`1948`	`1948`	`(references <link linkend="catalog-pg-tablespace"><structname>pg_tablespace</structname></link>.<structfield>oid</structfield>)`
`1949`	`1949`	`</para>`
`1950`	`1950`	`<para>`
`1951`		`- The tablespace in which this relation is stored. If zero,`
`1952`		`- the database's default tablespace is implied. (Not meaningful`
`1953`		`- if the relation has no on-disk file.)`
	`1951`	`+ The tablespace in which this relation is stored.`
	`1952`	`+ If zero, the database's default tablespace is implied.`
	`1953`	`+ Not meaningful if the relation has no on-disk file,`
	`1954`	`+ except for partitioned tables, where this is the tablespace`
	`1955`	`+ in which partitions will be created when one is not`
	`1956`	`+ specified in the creation command.`
`1954`	`1957`	`</para></entry>`
`1955`	`1958`	`</row>`
`1956`	`1959`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -715,10 +715,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,`
`715`	`715`	`}`
`716`	`716`	`else if (stmt->partbound)`
`717`	`717`	`{`
`718`		`-/*`
`719`		`- * For partitions, when no other tablespace is specified, we default`
`720`		`- * the tablespace to the parent partitioned table's.`
`721`		`- */`
`722`	`718`	`Assert(list_length(inheritOids) == 1);`
`723`	`719`	`tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));`
`724`	`720`	`}`

Comments

(0)