NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit51c24d9

committed

Fix ordering issue with WAL operations in GIN fast insert path

Contrary to what is documented in src/backend/access/transam/README,ginHeapTupleFastInsert() had a few ordering issues with the way it doesits WAL operations when inserting items in its fast path.First, when using a separate list, XLogBeginInsert() was being alwayscalled before START_CRIT_SECTION(), and in this case a second thing waswrong when merging lists, as an exclusive lock was taken on the tailpage *before* calling XLogBeginInsert(). Finally, when inserting itemsinto a tail page, the order of XLogBeginInsert() andSTART_CRIT_SECTION() was reversed. This commit addresses all theseissues by moving the calls of XLogBeginInsert() after all the pageslogged are locked and pinned, within a critical section.This has been applied first only on HEAD as of56b6625, but as perdiscussion with Tom Lane and Álvaro Herrera, a backpatch is preferred tokeep all the branches consistent and to respect the transam's READMEwhere we can.Author: Matthias van de Meent, Zhang MingliDiscussion:https://postgr.es/m/CAEze2WhL8uLMqynnnCu1LAPwxD5RKEo0nHV+eXGg_N6ELU88HQ@mail.gmail.comBackpatch-through: 10

1 parent475e9da commit51c24d9Copy full SHA for 51c24d9

File tree

1 file changed

-5

lines changed

src/backend/access/gin
- ginfast.c

1 file changed

-5

lines changed

`‎src/backend/access/gin/ginfast.c`

Lines changed: 8 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -284,9 +284,6 @@ ginHeapTupleFastInsert(GinState ginstate, GinTupleCollector collector)`
`284`	`284`	`memset(&sublist,0,sizeof(GinMetaPageData));`
`285`	`285`	`makeSublist(index,collector->tuples,collector->ntuples,&sublist);`
`286`	`286`
`287`		`-if (needWal)`
`288`		`-XLogBeginInsert();`
`289`		`-`
`290`	`287`	`/*`
`291`	`288`	`* metapage was unlocked, see above`
`292`	`289`	`*/`
`@@ -306,6 +303,9 @@ ginHeapTupleFastInsert(GinState ginstate, GinTupleCollector collector)`
`306`	`303`
`307`	`304`	`metadata->nPendingPages=sublist.nPendingPages;`
`308`	`305`	`metadata->nPendingHeapTuples=sublist.nPendingHeapTuples;`
	`306`	`+`
	`307`	`+if (needWal)`
	`308`	`+XLogBeginInsert();`
`309`	`309`	`}`
`310`	`310`	`else`
`311`	`311`	`{`
`@@ -334,7 +334,10 @@ ginHeapTupleFastInsert(GinState ginstate, GinTupleCollector collector)`
`334`	`334`	`metadata->nPendingHeapTuples+=sublist.nPendingHeapTuples;`
`335`	`335`
`336`	`336`	`if (needWal)`
	`337`	`+{`
	`338`	`+XLogBeginInsert();`
`337`	`339`	`XLogRegisterBuffer(1,buffer,REGBUF_STANDARD);`
	`340`	`+}`
`338`	`341`	`}`
`339`	`342`	`}`
`340`	`343`	`else`
`@@ -360,11 +363,11 @@ ginHeapTupleFastInsert(GinState ginstate, GinTupleCollector collector)`
`360`	`363`
`361`	`364`	`data.ntuples=collector->ntuples;`
`362`	`365`
	`366`	`+START_CRIT_SECTION();`
	`367`	`+`
`363`	`368`	`if (needWal)`
`364`	`369`	`XLogBeginInsert();`
`365`	`370`
`366`		`-START_CRIT_SECTION();`
`367`		`-`
`368`	`371`	`/*`
`369`	`372`	`* Increase counter of heap tuples`
`370`	`373`	`*/`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit51c24d9

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginfast.c`

0 commit comments